Merge pull request #2357 from internetee/2338-fix-syntax-error-in-epp…

…-2005 Fixed message format for epp 2005 error
internetee · Apr 18, 2022 · f21f347 · f21f347
2 parents 60165cc + bcd1b3f
commit f21f347
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 8 deletions.
diff --git a/app/interactions/actions/contact_create.rb b/app/interactions/actions/contact_create.rb
@@ -19,12 +19,12 @@ def call
     def maybe_change_email
       return if Rails.env.test?
 
-      [:regex, :mx].each do |m|
+      %i[regex mx].each do |m|
         result = Actions::SimpleMailValidator.run(email: contact.email, level: m)
-
         next if result
 
-        contact.add_epp_error('2005', nil, "email didn't pass validation", I18n.t(:parameter_value_syntax_error))
+        err_text = "email '#{contact.email}' didn't pass validation"
+        contact.add_epp_error('2005', nil, nil, "#{I18n.t(:parameter_value_syntax_error)} #{err_text}")
         @error = true
         return
       end

diff --git a/app/interactions/actions/contact_update.rb b/app/interactions/actions/contact_update.rb
@@ -23,11 +23,12 @@ def call
     def maybe_change_email
       return if Rails.env.test?
 
-      [:regex, :mx].each do |m|
+      %i[regex mx].each do |m|
         result = Actions::SimpleMailValidator.run(email: @new_attributes[:email], level: m)
         next if result
 
-        contact.add_epp_error('2005', nil, "email didn't pass validation", I18n.t(:parameter_value_syntax_error))
+        err_text = "email '#{new_attributes[:email]}' didn't pass validation"
+        contact.add_epp_error('2005', nil, nil, "#{I18n.t(:parameter_value_syntax_error)} #{err_text}")
         @error = true
         return
       end

diff --git a/app/interactions/actions/domain_update.rb b/app/interactions/actions/domain_update.rb
@@ -136,11 +136,12 @@ def start_validate_email(props)
     def validate_email(email)
       return true if Rails.env.test?
 
-      [:regex, :mx].each do |m|
+      %i[regex mx].each do |m|
         result = Actions::SimpleMailValidator.run(email: email, level: m)
         next if result
 
-        domain.add_epp_error('2005', nil, "#{email} didn't pass validation", I18n.t(:parameter_value_syntax_error))
+        err_text = "email #{email} didn't pass validation"
+        domain.add_epp_error('2005', nil, nil, "#{I18n.t(:parameter_value_syntax_error)} #{err_text}")
         @error = true
         return
       end

diff --git a/config/locales/en.yml b/config/locales/en.yml
@@ -371,7 +371,7 @@ en:
   sim_error: 'SIM application error'
   internal_error: 'Internal error'
   client_side_status_editing_error: 'Parameter value policy error. Client-side object status management not supported'
-  parameter_value_syntax_error: 'Parameter value syntax error: '
+  parameter_value_syntax_error: 'Parameter value syntax error:'
 
   # DEPP
   activemodel: