Merge pull request #1984 from internetee/1978-remove-activerecord-import

Remove activerecord-import gem
internetee · May 17, 2021 · 90b128f · 90b128f
2 parents 7ca3515 + abb918a
commit 90b128f
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 5 deletions.
diff --git a/Gemfile b/Gemfile
@@ -15,7 +15,6 @@ gem 'uglifier'
 gem 'figaro', '~> 1.2'
 
 # model related
-gem 'activerecord-import'
 gem 'paper_trail', '~> 12.0'
 gem 'pg',                        '1.2.3'
 # 1.8 is for Rails < 5.0

diff --git a/Gemfile.lock b/Gemfile.lock
@@ -124,8 +124,6 @@ GEM
     activerecord (6.1.3.2)
       activemodel (= 6.1.3.2)
       activesupport (= 6.1.3.2)
-    activerecord-import (1.0.8)
-      activerecord (>= 3.2)
     activestorage (6.1.3.2)
       actionpack (= 6.1.3.2)
       activejob (= 6.1.3.2)
@@ -515,7 +513,6 @@ PLATFORMS
 
 DEPENDENCIES
   active_interaction (~> 4.0)
-  activerecord-import
   airbrake
   apipie-rails (~> 0.5.18)
   aws-sdk-sesv2 (~> 1.16)

diff --git a/db/data/20200608084321_fill_email_verifications.rb b/db/data/20200608084321_fill_email_verifications.rb
@@ -12,7 +12,8 @@ def up
     # result = emails.map do |email|
     #   { email: email, domain: domain(email) }
     # end
-    # EmailAddressVerification.import result, batch_size: 500
+    # EmailAddressVerification.import result, batch_size: 500 #deprecated/removed
+    # need to use insert_all if uncommented
   end
 
   def down