Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added custom amounts for generating oneoff links #114

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Added custom amounts for generating oneoff links #114

wants to merge 5 commits into from

Conversation

maricavor
Copy link
Contributor

@maricavor maricavor commented Jun 6, 2024 •
edited
Loading

@maricavor maricavor requested a review from OlegPhenomenon June 26, 2024 07:16
OlegPhenomenon
OlegPhenomenon reviewed Jun 27, 2024
View reviewed changes
app/models/invoice.rb Outdated
def payment_reference_must_change
if payment_reference.present? && payment_reference == payment_reference_was
errors.add(:payment_reference, 'must be different from the existing payment reference')
end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think better will be

def payment_reference_must_change
    return unless payment_reference.present? && payment_reference == payment_reference_was

    errors.add(:payment_reference, 'must be different from the existing payment reference')
end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlegPhenomenon OlegPhenomenon OlegPhenomenon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable partial card payments
2 participants
@maricavor @OlegPhenomenon