Merge pull request #1241 from internetee/webpush-offer-nil-issue

prevent offer nil issue in webpush
internetee · Apr 18, 2024 · a89ebb6 · a89ebb6
2 parents fab50df + 169cb79
commit a89ebb6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/.gitignore b/.gitignore
@@ -55,4 +55,5 @@ yarn-debug.log*
 /public/assets/builds
 public/assets/builds/*
 app/assets/builds/*
+
 .DS_Store
diff --git a/app/controllers/concerns/offer_notifable.rb b/app/controllers/concerns/offer_notifable.rb
@@ -5,7 +5,8 @@ def send_outbided_notification(auction:, offer:, flash:)
     participant_id = last_higher_bidder(auction)
     participant = User.find(participant_id)
 
-    OfferNotification.with(offer: offer).deliver_later(participant)
+    OfferNotification.with(offer: offer).deliver_later(participant) if offer.present?
+
     flash[:notice] = "websocket_domain_name, #{auction.domain_name}"
     broadcast_outbid_to_notifications(participant: participant, flash: flash)
   end