Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve offline page by autoloading #10037

Merged
merged 2 commits into from
Nov 25, 2024
Merged

improve offline page by autoloading #10037

merged 2 commits into from
Nov 25, 2024

Conversation

RayBB
Copy link
Collaborator

@RayBB RayBB commented Nov 18, 2024

Related to #10034

  1. If the user's device comes online (they connect to wifi/data/etc) then we automatically reload the page

I think this minor change will lead to a great improvement in the experience for users with intermittent connections (such as being on a metro).

Technical

Testing

Screenshot

Stakeholders

@cdrini what do you think about this.

@RayBB RayBB marked this pull request as draft November 18, 2024 05:11
@RayBB RayBB marked this pull request as ready for review November 23, 2024 05:11
@RayBB RayBB requested a review from cdrini November 23, 2024 05:11
@RayBB RayBB added the Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. label Nov 23, 2024
@mekarpeles mekarpeles merged commit 00f61af into master Nov 25, 2024
6 checks passed
@mekarpeles mekarpeles self-assigned this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants