Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEBDEV-7022 Ensure initial page of results always triggers scroller refresh #402

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

latonv
Copy link
Contributor

@latonv latonv commented Sep 26, 2024

Broadens the conditions under which the infinite scroller's results will be refreshed, to always include the initial page of results (even when multiple pages are being loaded in simultaneously).

Copy link

github-actions bot commented Sep 26, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://internetarchive.github.io/iaux-collection-browser/pr/pr-402/
on branch gh-pages at 2024-10-09 17:51 UTC

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 76.36364% with 13 lines in your changes missing coverage. Please review.

Project coverage is 96.19%. Comparing base (99a3dcf) to head (2f2dc44).
Report is 31 commits behind head on main.

Files with missing lines Patch % Lines
src/collection-browser.ts 68.29% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #402      +/-   ##
==========================================
- Coverage   96.96%   96.19%   -0.77%     
==========================================
  Files          93       94       +1     
  Lines       15073    15801     +728     
  Branches      728      717      -11     
==========================================
+ Hits        14615    15200     +585     
- Misses        431      573     +142     
- Partials       27       28       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant