Shady dom css shifts #919
Shady dom css shifts #919
Conversation
Codecov Report
@@ Coverage Diff @@
## master #919 +/- ##
=======================================
Coverage 69.30% 69.30%
=======================================
Files 58 58
Lines 5151 5151
Branches 846 846
=======================================
Hits 3570 3570
Misses 1569 1569
Partials 12 12
Continue to review full report at Codecov.
|
|
#477 Strikes again! |
There was a problem hiding this comment.
- Fullscreen/normal working in FF, Chrome @ Win10
- Still getting black screen of doom on Safari 9 :/
- Safari 11 is showing the book, but missing the vertical toolbar; also on master branch
- The error is
ReferenceError: Can't find variable: globalThis; what's that polyfill file we need to add for lit 2? We should add it to the demo html
- The error is
- The sidebar now overlaps the view; the book isn't resizing 😬
| @@ -105,7 +105,7 @@ export class IaBookReader extends LitElement { | |||
|
|
|||
| render() { | |||
| return html` | |||
| <div class="ia-bookreader"> | |||
| <div class="main-component"> | |||
There was a problem hiding this comment.
Gaah, webcomponents/polyfills#477 ! Let's give this a tighter class name to avoid hitting other things; I started doing *_root; e.g. ia-bookreader__root so that it can't possibly in any way break/collide 😅
There was a problem hiding this comment.
TIL about polyfills class naming
|
thanks for the quick look @cdrini - i've set as draft as i tinker further. and thanks for the polyfill check. will add. |
updates to support flattened, shadydom
testing: go to https://deploy-preview-919--lucid-poitras-9a1249.netlify.app/bookreaderdemo/demo-internetarchive?ocaid=theworksofplato01platiala -> works ✅
using internetarchive/iaux-item-navigator#5