Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add protected option to text selection plugin #1142

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cdrini
Copy link
Contributor

@cdrini cdrini commented Jan 31, 2023

Closes #1140

Issues:

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #1142 (d03fe4a) into master (7914dfa) will decrease coverage by 0.14%.
The diff coverage is 21.42%.

❗ Current head d03fe4a differs from pull request most recent head 744192d. Consider uploading reports for the commit 744192d to get more accurate results

@@            Coverage Diff             @@
##           master    #1142      +/-   ##
==========================================
- Coverage   70.24%   70.10%   -0.14%     
==========================================
  Files          61       61              
  Lines        5162     5175      +13     
  Branches     1066     1071       +5     
==========================================
+ Hits         3626     3628       +2     
- Misses       1509     1520      +11     
  Partials       27       27              
Impacted Files Coverage Δ
src/plugins/plugin.text_selection.js 79.43% <21.42%> (-2.75%) ⬇️

@cdrini cdrini force-pushed the features/textsel-protected branch 3 times, most recently from d0e8932 to 9389505 Compare January 31, 2023 22:26
@cdrini cdrini force-pushed the features/textsel-protected branch from 9389505 to 744192d Compare July 3, 2023 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement tweaks to text selection prototype
1 participant