Fix unserialize() warning flood with PHP 8.3+. Fix deprecated warnings. #385
+96
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of PHP 8.3 unserialize() triggers E_WARNING instead of E_NOTICE causing SRDB to dump thousands of notices to the screen as it tries to unserialized non-serialized strings. It now checks for serialized data before trying to unserialize. Fixed Deprecation warning creating dynamic property: alter_collation. Fixed Deprecation warning when passing null to htmlentities().
Added v4.1.4 for unserialize() and Deprecated warning fixes.
mikecollet
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Yesterday I was using SRDB V4.1.3 running on the latest PHP version and encountered this problem. I have tested @colinfoster solution and it works perfectly!
mikecollet
approved these changes
Apr 8, 2024
Slamik
approved these changes
Apr 9, 2024
BackuPs
approved these changes
Apr 9, 2024
|
8.3.9 works fine. Noticed the merge and review went unanswered here so people wanting these changes ( thanks to @colinfoster via #385 ) should grab the updates over @ https://github.com/colinfoster/Search-Replace-DB/ |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of PHP 8.3 unserialize() triggers E_WARNING instead of E_NOTICE causing SRDB to dump thousands of notices (one for every string checked) to the screen as it tries to unserialize non-serialized strings. It now checks for serialized data before trying to unserialize.
Fixed Deprecation warning creating dynamic property: alter_collation.
Fixed Deprecation warning when passing null to htmlentities().