-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump nanoid and mocha #237
Conversation
It looks like you are reviewing a Dependabot upgrade PR! 🛠️ We aim to merge Dependabot PRs within the below timeframes. The objectives are based on the severity of the security vulnerability we are mitigating with the upgrade:
🎯 Target merge date for this PR: 10/03/2025 🎯 FAQ What if we aren’t vulnerable to this particular CVE? Do we still have to upgrade the package?It’s still a good idea to upgrade the package if we can. With new code patterns and paths being introduced every day, we have no guarantee that we won’t later make ourselves vulnerable. Keeping packages up to date as a matter of due course is also good hygiene.What if we’re not vulnerable and upgrading is going to be a lot of work?In these cases it’s a good idea to list out the steps you took to confirm we are not vulnerable in this PR. The PR can then be closed and the corresponding Dependabot Alert should be dismissed with the triage steps included as a comment. Please get in touch with Team Application Security via #ask-security before dismissing anyCRITICAL alerts.
This is a major version upgrade that requires substantial code refactoring. What should I do?If the upgrade requires substantial refactoring then it is possible that we will miss the objectives we have outlined above. In these cases, you should add thedependabot-refactor-required label to this PR and ping #ask-security for further advice.
|
f10d9ce
to
aa35965
Compare
Removes [nanoid](https://github.com/ai/nanoid). It's no longer used after updating ancestor dependency [mocha](https://github.com/mochajs/mocha). These dependencies need to be updated together. Removes `nanoid` Updates `mocha` from 10.2.0 to 10.8.2 - [Release notes](https://github.com/mochajs/mocha/releases) - [Changelog](https://github.com/mochajs/mocha/blob/main/CHANGELOG.md) - [Commits](mochajs/mocha@v10.2.0...v10.8.2) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect - dependency-name: mocha dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
aa35965
to
127c38f
Compare
Hello @intercom/team-messenger 👋 this PR fixes a security vulnerability (GHSA-mwcw-c2x4-8c55) in a repository you own - intercom/intercom-react-native. We have obligation to update our dependencies in a timely manner in order to keep our applications secure. Please take a look at the PR and merge it as soon as possible. |
@dependabot rebase |
Looks like this PR is already up-to-date with main! If you'd still like to recreate it from scratch, overwriting any edits, you can request |
@dependabot squash and merge |
Dependabot tried to merge this PR, but received the following error from GitHub:
|
Fixes intercom/intercom#371373. Removes nanoid. It's no longer used after updating ancestor dependency mocha. These dependencies need to be updated together.
Removes
nanoid
Updates
mocha
from 10.2.0 to 10.8.2Release notes
Sourced from mocha's releases.
... (truncated)
Changelog
Sourced from mocha's changelog.
... (truncated)
Commits
05097db
chore(main): release 10.8.2 (#5239)14e640e
docs: indicate 'exports' interface does not work in browsers (#5181)881e3b0
chore: fix docs builds by re-adding eleventy and ignoring gitignore again (#5...f054acc
fix: test link in html reporter (#5224)e536ab2
build(deps): bump the github-actions group with 1 update (#5132)ba0fefe
fix: support errors with circular dependencies in object values with --parall...f44f71b
chore(main): release 10.8.1 (#5238)f72bc17
fix: handle case of invalid package.json with no explicit config (#5198)68803b6
fix: use accurate test links in HTML reporter (#5228)d8ca270
fix: Typos on mochajs.org (#5237)Maintainer changes
This version was pushed to npm by voxpelli, a new releaser for mocha since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.