Skip to content

Commit

Permalink
Merge pull request #117 from CodeLingoBot/rewrite
Browse files Browse the repository at this point in the history
Fix function comments based on best practices from Effective Go
  • Loading branch information
SeanHealy33 authored Mar 19, 2019
2 parents a7c3571 + 8a8e0fb commit 1dbafb0
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion admin.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ func (a Admin) IsNobodyAdmin() bool {
return a.Type == "nobody_admin"
}

// Get the address for a Contact in order to message them
// MessageAddress gets the address for a Contact in order to message them
func (a Admin) MessageAddress() MessageAddress {
return MessageAddress{
Type: "admin",
Expand Down
2 changes: 1 addition & 1 deletion contact.go
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ func (c *ContactService) Delete(contact *Contact) (Contact, error) {
return c.Repository.delete(contact.ID)
}

// Get the address for a Contact in order to message them
// MessageAddress gets the address for a Contact in order to message them
func (c Contact) MessageAddress() MessageAddress {
return MessageAddress{
Type: "contact",
Expand Down
2 changes: 1 addition & 1 deletion intercom.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ func NewClient(appID, apiKey string) *Client {
return &intercom
}

// Returns a new Intercom API client, configured with the supplied HTTPClient interface
// NewClientWithHTTPClient returns a new Intercom API client, configured with the supplied HTTPClient interface
func NewClientWithHTTPClient(appID, apiKey string, httpClient interfaces.HTTPClient) *Client {
intercom := Client{AppID: appID, APIKey: apiKey, baseURI: defaultBaseURI, debug: false, clientVersion: clientVersion, HTTPClient: httpClient}
intercom.setup()
Expand Down
2 changes: 1 addition & 1 deletion user.go
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ func (u *UserService) Delete(id string) (User, error) {
return u.Repository.delete(id)
}

// Get the address for an User in order to message them
// MessageAddress gets the address for an User in order to message them
func (u User) MessageAddress() MessageAddress {
return MessageAddress{
Type: "user",
Expand Down

0 comments on commit 1dbafb0

Please sign in to comment.