This repository has been archived by the owner on Mar 5, 2024. It is now read-only.
Make structs platform agnostic #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 19, 2019 14:35
Change unsigned int to uint32_t in places that we are assuming that they are 4 bytes. Signed-off-by: Flavio Ceolin <[email protected]>
|
@mczraf can you take a look on it ? |
utzig
reviewed
Mar 13, 2020
| tests/test_ecc_dsa | ||
| tests/test_hmac | ||
| tests/test_hmac_prng | ||
| tests/test_sha256 |
There was a problem hiding this comment.
This could be written:
tests/test_*
!tests/test_*.c
Hopefully without side-effects, and with no need of updates when new tests are added. And I would add tags to .gitignore as well!
|
Looks correct to me! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.