Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

Remove redundant spdm-mbedtls-hashed-transcript-data #81

Merged
merged 1 commit into from
Sep 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,8 @@ jobs:
RUSTFLAGS: "-C instrument-coverage"
CC_x86_64_unknown_none: clang
AR_x86_64_unknown_none: llvm-ar
RUN_REQUESTER_FEATURES: "spdm-mbedtls,hashed-transcript-data,spdm-mbedtls-hashed-transcript-data"
RUN_RESPONDER_FEATURES: "spdm-mbedtls,hashed-transcript-data,spdm-mbedtls-hashed-transcript-data"
RUN_REQUESTER_FEATURES: "spdm-mbedtls,hashed-transcript-data"
RUN_RESPONDER_FEATURES: "spdm-mbedtls,hashed-transcript-data"
run: |
./sh_script/build.sh -r

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,14 @@ jobs:
"spdm-ring",
"spdm-ring,hashed-transcript-data",
"spdm-mbedtls",
"spdm-mbedtls,hashed-transcript-data,spdm-mbedtls-hashed-transcript-data",
"spdm-mbedtls,hashed-transcript-data",
]
run_responder_features:
[
"spdm-ring",
"spdm-ring,hashed-transcript-data",
"spdm-mbedtls",
"spdm-mbedtls,hashed-transcript-data,spdm-mbedtls-hashed-transcript-data",
"spdm-mbedtls,hashed-transcript-data",
]
include:
- runs-on: windows-latest
Expand Down
4 changes: 2 additions & 2 deletions readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ The following list shows the supported combinations for both spdm-requester-emu
| spdm-ring | ring | No | use ring as crypto library with hashed-transcript-data disabled |
| spdm-ring,hashed-transcript-data | ring | Yes | use ring as crypto library with hashed-transcript-data enabled |
| spdm-mbedtls | mbedtls | No | use mbedtls as crypto library with hashed-transcript-data disabled |
| spdm-mbedtls,hashed-transcript-data,spdm-mbedtls-hashed-transcript-data | mbedtls | Yes | use mbedtls as crypto library with hashed-transcript-data |
| spdm-mbedtls,hashed-transcript-data | mbedtls | Yes | use mbedtls as crypto library with hashed-transcript-data |

For example, run the emulator with spdm-ring enabled and without hashed-transcript-data enabled.
Open one command windows and run:
Expand All @@ -133,7 +133,7 @@ cargo run -p spdm-responder-emu --no-default-features --features "spdm-ring"
run the emulator with spdm-mbedtls enabled and with hashed-transcript-data enabled.
Open another command windows and run:
```
cargo run -p spdm-requester-emu --no-default-features --features "spdm-mbedtls,hashed-transcript-data,spdm-mbedtls-hashed-transcript-data"
cargo run -p spdm-requester-emu --no-default-features --features "spdm-mbedtls,hashed-transcript-data"
```

NOTE: In order to run the emu without hashed-transcript-data, please change `max_cert_chain_data_size` in `spdmlib/etc/config.json` from `4096` to `3500`.
Expand Down
3 changes: 1 addition & 2 deletions test/spdm-emu/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,4 @@ default = ["spdm-ring", "spdmlib/hashed-transcript-data"]
mut-auth = ["spdmlib/mut-auth"]
spdm-ring = ["spdmlib/spdm-ring", "spdmlib/std"]
spdm-mbedtls = ["spdmlib_crypto_mbedtls"]
hashed-transcript-data = ["spdmlib/hashed-transcript-data"]
spdm-mbedtls-hashed-transcript-data = ["spdmlib_crypto_mbedtls/hashed-transcript-data"]
hashed-transcript-data = ["spdmlib/hashed-transcript-data", "spdmlib_crypto_mbedtls?/hashed-transcript-data"]
1 change: 0 additions & 1 deletion test/spdm-requester-emu/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,3 @@ mut-auth = ["spdm-emu/mut-auth"]
spdm-ring = ["spdm-emu/spdm-ring"]
spdm-mbedtls = ["spdm-emu/spdm-mbedtls"]
hashed-transcript-data = ["spdm-emu/hashed-transcript-data"]
spdm-mbedtls-hashed-transcript-data = ["spdm-emu/spdm-mbedtls-hashed-transcript-data"]
1 change: 0 additions & 1 deletion test/spdm-responder-emu/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,3 @@ mut-auth = ["spdm-emu/mut-auth"]
spdm-ring = ["spdm-emu/spdm-ring"]
spdm-mbedtls = ["spdm-emu/spdm-mbedtls"]
hashed-transcript-data = ["spdm-emu/hashed-transcript-data"]
spdm-mbedtls-hashed-transcript-data = ["spdm-emu/spdm-mbedtls-hashed-transcript-data"]
Loading