Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

remove Unknow(0) from SpdmVersion. #79

Merged
merged 1 commit into from
Sep 12, 2023
Merged

remove Unknow(0) from SpdmVersion. #79

merged 1 commit into from
Sep 12, 2023

Conversation

longlongyang
Copy link
Contributor

fix #73

@longlongyang
Copy link
Contributor Author

benchmark on this PR:

ls -ll ../target/x86_64-unknown-none/release/libspdmlib.rlib
-rw-r--r-- 2 longlong longlong 5709194 Sep 11 22:04 ../target/x86_64-unknown-none/release/libspdmlib.rlib

N-1 commit:
ls -ll ../target/x86_64-unknown-none/release/libspdmlib.rlib
-rw-r--r-- 2 longlong longlong 5737532 Sep 11 22:08 ../target/x86_64-unknown-none/release/libspdmlib.rlib

saved ~27KB

reproducible:

pushd spdmlib
cargo build -Z build-std=core,alloc,compiler_builtins --target x86_64-unknown-none --release --no-default-features --features="spdm-ring"

@jyao1 jyao1 merged commit 2a63dba into intel:main Sep 12, 2023
26 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SpdmVersion has a unkown(0) state, which is error prone
2 participants