add support to export the full transcript (VCA + message_m) #109
Conversation
longlongyang
force-pushed
the
i29
branch
2 times, most recently
from
bf3b975 to
7a61c37
Compare
| async fn send_receive_spdm_measurement_record( | ||
| &mut self, | ||
| session_id: Option<u32>, | ||
| measurement_attributes: SpdmMeasurementAttributes, | ||
| measurement_operation: SpdmMeasurementOperation, | ||
| spdm_measurement_record_structure: &mut SpdmMeasurementRecordStructure, | ||
| transcript_vca: &mut Option<ManagedBufferA>, | ||
| transcript_meas: &mut Option<ManagedBufferM>, |
There was a problem hiding this comment.
If the caller needs to invoke send_receive_spdm_measurement_record() multiple times, then transcript_vca will be copied multiple times.
That is not efficient.
Can we do that in init_connection()?
There was a problem hiding this comment.
If the caller needs to invoke send_receive_spdm_measurement_record() multiple times, then transcript_vca will be copied multiple times.
That is not efficient.
Can we do that in init_connection()?
Sure, updated.
longlongyang
force-pushed
the
i29
branch
2 times, most recently
from
e7b5803 to
b15c963
Compare
longlongyang
changed the title
| ret_message_m | ||
| .append_message(&receive_buffer[..temp_used]) | ||
| .ok_or(SPDM_STATUS_BUFFER_FULL)?; | ||
| } | ||
|
|
||
| // verify signature | ||
| if measurement_attributes |
There was a problem hiding this comment.
Need append signature
updated.
|
Please also resolve conflict |
longlongyang
force-pushed
the
i29
branch
4 times, most recently
from
83dac53 to
ad57419
Compare
resolved. |
|
Need test to ensure the digital signature can be verified. |
longlongyang
force-pushed
the
i29
branch
3 times, most recently
from
f3ce55a to
6eb7223
Compare
new test function added. |
|
Looks good. We probably need add one more test to cover one-by-one mode. |
fix intel#29 Signed-off-by: Yang, Longlong <[email protected]>
one-by-one mode added. |
fix #29