Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Adds human pose estimation #177

Open
wants to merge 20 commits into
base: dev-ov2020.3
Choose a base branch
from

Conversation

silasalves
Copy link

@silasalves silasalves commented Jun 30, 2021

Adds support to human-pose-estimation-0001 network to the new development branch, as suggested in the previous pull request.

chaoli2 and others added 20 commits May 5, 2019 10:53
merge devel to master for 0.5.0 release
to solve CMake Error at /opt/ros/kinetic/share/genmsg/cmake/genmsg-extras.cmake:263 (message):
  Messages depends on unknown pkg: object_msgs (Missing
  'find_package(object_msgs)'?)
people_msgs package name is changed to vino_people_msgs
Name Changes for sample and dynamic_vino_lib packages.
@LewisLiuPub
Copy link
Contributor

@silasalves
Thank you very much for your quick response.
There are some conflicts between your patches and the original code of the branch, mostly because of the naming changes in branch master.

To simplify the PR's merge, do you think it would be a good idea to merge Master's new patches to this branch?

Thanks a lot.

@LewisLiuPub
Copy link
Contributor

oh, you have already merged master's new patches to this branch, that's good. Thanks. @silasalves

@Corsair-cxs, since you are now contributing to this branch, please pay attention to the changes in this PR.

@LewisLiuPub
Copy link
Contributor

@silasalves
Hi, Silas, per our check, the patches you integrated into Branch dev-ov2020.3 can't pass build, because of some old code of OpenVINO and ROS versions.
I am wondering if we can restructure your contributions into 2 phase:

  1. Enable Human pose feature. (@Corsair-cxs has already published one PR: Adds human pose estimation support #178 , I will add you in the contributor list, if you agree.)
  2. Change folder names following the way you did, after the Human pose feature passes the func test based on OpenVINO 2020.3LTS version.

Please let me know if you have different points.
Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants