Embed OpenCL tracing files in the repo #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Formerly these were obtained from a fixed commit from https://github.com/intel/compute-runtime.git. This has no advantage compared with directly embedding the files. It makes the tools hard to build on a cluster without internet access. The git hash from which the embedded copies are taken was ca7d47598a63959d42750c62a2981e08ffa392a1 and has been recorded in those files. That was the only modification to the files. The copies were embedded in a subdirectory matching those from the repo from which they were taken, so no modifications to these files are needed in order to use them. All tools in this repo already add the utils subdirectory as a directory in which the compiler should search. Also minor related changes and simplifications.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formerly these were obtained from a fixed commit from https://github.com/intel/compute-runtime.git. This has no advantage compared with directly embedding the files. It makes the tools hard to build on a cluster without internet access.
The git hash from which the embedded copies are taken was ca7d47598a63959d42750c62a2981e08ffa392a1 and has been recorded in those files. That was the only modification to the files.
The copies were embedded in a subdirectory matching those from the repo from which they were taken, so no modifications to these files are needed in order to use them. All tools in this repo already add the utils subdirectory as a directory in which the compiler should search.
Also minor related changes and simplifications.