This repository has been archived by the owner on Aug 5, 2022. It is now read-only.
tinyalsa: Fix tinyalsa plugin build issue for Android. #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TinyAlsa part of ALSA plugin was not compiling on Upstream version for Android integration. This patch is fixing the compilation issue. It has been tested under Android IA tree. Signed-off-by: Sebastien Guiriec <[email protected]>
cc6565
reviewed
Mar 30, 2017
| @@ -39,7 +39,7 @@ extern "C" | |||
| * It will then create an TinyAMixer Subsystem | |||
| */ | |||
| void PARAMETER_FRAMEWORK_PLUGIN_ENTRYPOINT_V1(CSubsystemLibrary *subsystemLibrary, | |||
| core::log::Logger&) | |||
| core::log::Logger& logger) | |||
There was a problem hiding this comment.
coding rule: space before & and not after ;-)
added 3 commits
March 30, 2017 10:28
Signed-off-by: Sebastien Guiriec <[email protected]>
This patch introduces generic clang-format coding style for any new update of Parameter Framework ALSA plugin. Signed-off-by: Sebastien Guiriec <[email protected]>
This patch is updating the full plugin source code according to Parameter Framework coding rules with clang-format tool. Signed-off-by: Sebastien Guiriec <[email protected]>
sguiriec
force-pushed
the
sgc/topic/tinyalsa
branch
from
e028aa1
to
36885ce
Compare
cc6565
approved these changes
Mar 30, 2017
|
Need to be aligned with former tinyalsa branch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TinyAlsa part of ALSA plugin was not compiling on Upstream version for
Android integration. This patch is fixing the compilation issue. It has been
tested under Android IA tree.
Signed-off-by: Sebastien Guiriec [email protected]