Improve handling of large cascade plots #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a single function to generate platform labels for both matplotlib and pgfplots backends. Signed-off-by: John Pennycook <[email protected]>
Two letter labels are spreadsheet-style: AA, AB, AC, AD... Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
laserkelvin
approved these changes
Sep 24, 2024
|
|
||
|
|
||
| def _get_platform_labels(platforms: list[str]) -> dict[str, str]: | ||
| """ |
There was a problem hiding this comment.
Missing argument in docstring
There was a problem hiding this comment.
Fixed in 6471f60.
Add missing Parameters section. Signed-off-by: John Pennycook <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Closes #39.
Proposed changes
Clearly 676 platforms is too many, and I don't think anybody will ever want to produce such a large plot. But this change allows us to handle plots with many platforms without crashing. There will still be cases where the plot is unreadable, but the user can work around that by increasing the plot size.
Here's an example of 30 platforms, where the default is now readable:
By the time we hit 50 platforms, things are pretty squished:
I'm pretty happy with this as a fix for now, because most studies I've seen in real life use somewhere between 1-10 platforms. Fixing this for the general case will require some assistance from somebody who has a better grasp of how things like font sizes and plot sizes are connected in matplotlib.