Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix navchart column #68

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Fix navchart column #68

merged 2 commits into from
Sep 18, 2024

Conversation

Pennycook
Copy link
Contributor

Due to a copy-paste error, NavChart was looking for columns with the "eff" suffix instead of columns with the "pp" suffix.

Related issues

N/A

Proposed changes

  • Check for the correct columns in both matplotlib and pgfplots backends.
  • Add a simple regression test to make sure we don't accidentally break this again.

Due to a copy-paste error, NavChart was looking for columns with the
"eff" suffix instead of columns with the "pp" suffix.

Signed-off-by: John Pennycook <[email protected]>
@Pennycook Pennycook added the bug Something isn't working label Sep 13, 2024
@Pennycook Pennycook added this to the 1.0.0 milestone Sep 13, 2024
Copy link
Contributor

@laserkelvin laserkelvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

laserkelvin

This comment was marked as duplicate.

@Pennycook Pennycook merged commit 4186665 into intel:main Sep 18, 2024
7 checks passed
@Pennycook Pennycook deleted the fix-navchart-column branch September 18, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants