Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure application order is respected in cascade #63

Closed
wants to merge 3 commits into from

Commits on Aug 14, 2024

  1. Ensure application order is respected in cascade

    Dropping results from the df might lead to df["application"].unique()
    returning a different list of applications. The order of applications in
    this list determines the order in which applications are plotted.
    
    In order to respect the order of applications in the original DataFrame,
    and thereby ensure that cascade and navchart plots produced from the
    same projection use the same legend, we need to ensure that we do not
    change the application order.
    
    Signed-off-by: John Pennycook <[email protected]>
    Pennycook committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    e0318d1 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. Ensure application order is respected in navchart

    Plotting a NavChart requires a calculation of performance portability,
    which may adjust the order of applications in the DataFrame.
    
    Signed-off-by: John Pennycook <[email protected]>
    Pennycook committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    59ccc5a View commit details
    Browse the repository at this point in the history
  2. Update pp test to match new sorting behavior

    The previous "expected" test result had actually been chosen based on
    the empirical behavior of the library. If we expect the output of the
    DataFrame to remain sorted by application, we should test for that.
    
    Signed-off-by: John Pennycook <[email protected]>
    Pennycook committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    07285d8 View commit details
    Browse the repository at this point in the history