This repository has been archived by the owner on Jul 18, 2024. It is now read-only.
refactoring work in nn-hal #117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shouldn't need to call allocate() of a blob object if it was created with the constructor variant which already called allocate().
Assuming we believe these blobs should be deallocated (likely from a true returned from allocate()), the adding log will give us a hint when the unexpected happens, and it does in runtime.
The 'buf' is not used anymore before the function returns,so there is no need to reset it.
The class member mOpIndex2BlobMap is not really used any more, but it holds blobs which are shared pointers. There is a potential case of failing to release the blob resource because of the useless mOpIndex2BlobMap is still holding it. We'd better get rid of such unnecessary reference before it becomes a real obscure bug later.
This function is not used...
We cannot dereference mBuilderModel when it is null. That surely will crash the process.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anisha and other maintainers,
These patches are NOT fully tested, so please have a serious look and have someone help to validate them.