This repository has been archived by the owner on Aug 30, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 38
Add Fused-Attention Layer for AVX2 Platforms #137
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
airMeng
reviewed
Feb 22, 2024
luoyu-intel
reviewed
Feb 22, 2024
luoyu-intel
suggested changes
Feb 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better make mha_dense files as simple as ffn or qkv. It's too complicated for these compiler flags and intrinsic codes.
luoyu-intel
approved these changes
Feb 26, 2024
airMeng
approved these changes
Feb 26, 2024
Merged
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change: feature
API not changed.
Description
As title. In addition, add NE_ATTN_PREFER_FP32 to use f32 compute type on AVX512 platforms.
How has this PR been tested?
Local tests && CI
Windows 11 - 10th Gen Desktop
Intel(R) Core(TM) i9-10900 CPU @ 2.80GHz | q4-j-f32-g128 | 1002-token-prompt
Details:
Ubuntu - MTL
gtax (Client 3259) | q4-j-int8-g128 | 1332-token-prompt
Details:
Accuracy (Ubuntu - MTL)
LGTM
Dependency Change?
N/A