[SYCL] Fixed-size groups and partitions are renamed to "chunks" #16151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreiZibrov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
AndreiZibrov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
AndreiZibrov
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
AndreiZibrov
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
AndreiZibrov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AndreiZibrov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
approved these changes
Nov 25, 2024
| @@ -157,7 +156,7 @@ template <typename T, int N> struct get_elem_type_unqual<vec<T, N>> { | |||
| template <typename VecT, typename OperationLeftT, typename OperationRightT, | |||
| template <typename> class OperationCurrentT, int... Indexes> | |||
| struct get_elem_type_unqual<SwizzleOp<VecT, OperationLeftT, OperationRightT, | |||
| OperationCurrentT, Indexes...>> { | |||
| OperationCurrentT, Indexes...>> { | |||
There was a problem hiding this comment.
Strictly speaking, there should be no unrelated formatting changes, but in this particular case it is more of a nitpicking and can be ignored.
There was a problem hiding this comment.
the formatting task failed until I called clang-format -i per changed file
strictly:
cd ../llvm &&
git diff --cached --name-only --diff-filter=ACM | grep '\.[ch]pp$'|xargs -I{} clang-format -i```
|
As @steffenlarsen said in the original #15721, we should change all non-uniform groups at about the same time, so let's keep this one as a draft until other PRs for other non-uniform groups are ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1: fix for #15721 review