[SYCL][COMPAT] Extended vectorized_binary support to logical operators + Tests #15759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OuadiElfarouki
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
OuadiElfarouki
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
joeatodd
changed the title
Alcpz
requested changes
Oct 22, 2024
There was a problem hiding this comment.
Thanks for finding out why this didn't work @OuadiElfarouki!
Alcpz
approved these changes
Oct 24, 2024
|
@intel/llvm-gatekeepers This should be ready, thank you! |
|
@OuadiElfarouki got some merge conflicts to resolve first |
OuadiElfarouki
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
OuadiElfarouki
force-pushed
the
compat_vect_bin
branch
from
224531e
to
7a87e96
Compare
OuadiElfarouki
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
OuadiElfarouki
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-gatekeepers Hi again, it should be ready now. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add support for logical operators with
vectorized_binaryas well as the relevant unit-tests.