-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Support sycl_khr_default_context #15645
base: sycl
Are you sure you want to change the base?
Conversation
Spec: KhronosGroup/SYCL-Docs#624 sycl-cts: KhronosGroup/SYCL-CTS#960 This patch is intended to be merged only when there are sycl-cts tests and the ratified khr extension.
It looks like those tests are for the oneAPI extension |
@gmlueck as far as I understand you said that there is no sense to have |
Oh, I see. If @0x12CC is going to update KhronosGroup/SYCL-CTS#960, then everything is good. |
Sorry, I missed this discussion earlier. I've updated KhronosGroup/SYCL-CTS#960 to test the KHR extension instead. |
@KornevNikita now that KhronosGroup/SYCL-CTS#960 is updated, is there some way for you to check that the changes in this PR pass those tests? The Khronos SYCL WG is waiting for us to say that we have an implementation that passes those tests. Once we can say that, I think we can move forward with finalizing the KHR specification. |
@gmlueck is it enough to say "yes, we can pass them" or we need some result available online? |
I think the WG will trust us, so I think it is sufficient to say "yes, we pass them". Of course, we really should run the tests to make sure that they do pass. |
@gmlueck okay, then I'll check that and provide an update. |
@gmlueck yes, we can pass new tests with this patch. |
Spec: KhronosGroup/SYCL-Docs#624
sycl-cts: KhronosGroup/SYCL-CTS#960
This patch is intended to be merged only when there are sycl-cts tests and the ratified khr extension.