Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UR] phase 2 of counter-based event #15588

Merged
merged 7 commits into from
Oct 15, 2024

Conversation

winstonzhang-intel
Copy link
Contributor

@aarongreig aarongreig marked this pull request as ready for review October 15, 2024 13:32
@aarongreig aarongreig requested a review from a team as a code owner October 15, 2024 13:32
@aarongreig
Copy link
Contributor

@intel/llvm-gatekeepers please merge

@sarnex sarnex merged commit 66f2868 into intel:sycl Oct 15, 2024
12 checks passed
@sarnex
Copy link
Contributor

sarnex commented Oct 15, 2024

@aarongreig @winstonzhang-intel Seeing this failure in postcommit:

https://github.com/intel/llvm/actions/runs/11349817562/job/31567246324

FAIL: SYCL :: syclcompat/util/util_shift_sub_group_right.cpp (2208 of 2211)
Exit Code: -6

Command Output (stdout):
--
# RUN: at line 34
/__w/llvm/llvm/toolchain/bin//clang++  -Werror  -Wno-error=#warnings -Wno-error=deprecated-declarations -fsycl -fsycl-targets=spir64  /__w/llvm/llvm/llvm/sycl/test-e2e/syclcompat/util/util_shift_sub_group_right.cpp -o /__w/llvm/llvm/build-e2e/syclcompat/util/Output/util_shift_sub_group_right.cpp.tmp.out
# executed command: /__w/llvm/llvm/toolchain/bin//clang++ -Werror '-Wno-error=#warnings' -Wno-error=deprecated-declarations -fsycl -fsycl-targets=spir64 /__w/llvm/llvm/llvm/sycl/test-e2e/syclcompat/util/util_shift_sub_group_right.cpp -o /__w/llvm/llvm/build-e2e/syclcompat/util/Output/util_shift_sub_group_right.cpp.tmp.out
# .---command stderr------------
# | In file included from /__w/llvm/llvm/llvm/sycl/test-e2e/syclcompat/util/util_shift_sub_group_right.cpp:38:
# | In file included from /__w/llvm/llvm/toolchain/bin/../include/syclcompat.hpp:25:
# | In file included from /__w/llvm/llvm/toolchain/bin/../include/syclcompat/syclcompat.hpp:27:
# | /__w/llvm/llvm/toolchain/bin/../include/syclcompat/device.hpp:421:2: warning: "Querying the number of bytes of free memory is not supported" [-W#warnings]
# |   421 | #warning "Querying the number of bytes of free memory is not supported"
# |       |  ^
# | 1 warning generated.
# | In file included from /__w/llvm/llvm/llvm/sycl/test-e2e/syclcompat/util/util_shift_sub_group_right.cpp:38:
# | In file included from /__w/llvm/llvm/toolchain/bin/../include/syclcompat.hpp:25:
# | In file included from /__w/llvm/llvm/toolchain/bin/../include/syclcompat/syclcompat.hpp:27:
# | /__w/llvm/llvm/toolchain/bin/../include/syclcompat/device.hpp:421:2: warning: "Querying the number of bytes of free memory is not supported" [-W#warnings]
# |   421 | #warning "Querying the number of bytes of free memory is not supported"
# |       |  ^
# | 1 warning generated.
# `-----------------------------
# RUN: at line 35
env ONEAPI_DEVICE_SELECTOR=level_zero:gpu  /__w/llvm/llvm/build-e2e/syclcompat/util/Output/util_shift_sub_group_right.cpp.tmp.out
# executed command: env ONEAPI_DEVICE_SELECTOR=level_zero:gpu /__w/llvm/llvm/build-e2e/syclcompat/util/Output/util_shift_sub_group_right.cpp.tmp.out
# .---command stdout------------
# | void test_shift_sub_group_right()
# `-----------------------------
# .---command stderr------------
# | util_shift_sub_group_right.cpp.tmp.out: /__w/llvm/llvm/llvm/sycl/test-e2e/syclcompat/util/util_shift_sub_group_right.cpp:50: void verify_data(T *, T *, int, int) [T = unsigned int]: Assertion `data[i] == expect[i]' failed.
# `-----------------------------
# error: command failed with exit status: -6

Could it be related to this PR?

@aarongreig
Copy link
Contributor

@sarnex I did a quick A/B test and it looks like this change is responsible for the new fail, I won't have bandwidth to look into this myself so we should revert until @winstonzhang-intel has a chance to look into it

@aarongreig
Copy link
Contributor

revert PR #15720

@sarnex
Copy link
Contributor

sarnex commented Oct 16, 2024

@aarongreig Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants