Code Review Process

1. start work on libyami by 'fork' it to your home

2. commit/push to your home's repo, test it on ubuntu/centos

   • please reference any issues in your git commit message body (https://help.github.com/articles/closing-issues-using-keywords/)

3. create 'pull requests'

4. wait for other's review

5. update your home's repo following feedbacks
   we recommend force update to avoid unnecessary commit history, your pull requests get update automatically.

6. repeat the above two steps until no disagree

7. you can integrate your patch (home repo) with the condition met:
   

   • 1+ member flags ok when patches are less than 50 lines.
     
   • 2+ members flag ok when patches are more than 50 lines
     
   • at least one work day passed after latest patch update
     

8. integrate the patches manually (NOT the button on web page)
   

   • git push [email protected]/01org/libyami.git HEAD:apache
     

   we do not use the 'Merge pull request' button on web page, because:
   

   • it creates redundant commit log.
     
   • it creates unclear parent-child relation between commits when two merge requests basing on unique commit id.
     

9. now, the pull request is automatically close on web page.