Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encode segmentation map refine #744

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

leyu-yao
Copy link
Contributor

No description provided.

@@ -666,7 +666,8 @@ typedef struct _VAEncPictureParameterBufferAV1 {
* 0: 16x16 block size, default value;
* 1: 32x32 block size;
* 2: 64x64 block size;
* 3: 8x8 block size.
* 3: 8x8 block size;
* 4: 4x4 block size.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any value is ok? or backend driver only accept part of them? if so , may need a capability attributes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Av1 does have a caps report for it. https://github.com/intel/libva/blob/02eed8a57faadcd7f0e5e999723286ed160bd2bd/va/va_enc_av1.h#L154C18-L154C47
This change in comment is for interface completeness. In av1 spec, 4x4 block is allowed.
From av1 spec: Segmentation map
A 3-bit number containing the segment affiliation for each 4x4 block in the image.

va/va_enc_vp9.h Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants