Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add va_dec_avs & va_dec_avs2 #738

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

gitgjogh
Copy link

@gitgjogh gitgjogh commented Jul 25, 2023

add VAProfileAVSJizhun and VAProfileAVSGuangdian
add VAProfileAVS2Main and VAProfileAVS2Main10

Signed-off-by: jianfeng.zheng [email protected]

@gitgjogh
Copy link
Author

gitgjogh commented Jul 25, 2023

Hi there,

I'm grad to announce that we, Moore Threads, have finished Chinese AVS&AVS2 hwaccel decoding under FFMpeg-VAAPI framework. As mentioned before in #664, all our public products, MTT S10/MTT S50/MTT S80/MTT S2000/... support AVS&AVS+ decoding at max 2K and support AVS2 Main&Main10 decoding at max 8K.

This PR is the patches for libva.

For FFmpeg implementaion, please refer to

gitgjogh/FFmpeg#1

I will also submit the corresponding patches to FFMpeg lately.

Thanks,
Jianfeng

Copy link
Contributor

@dvrogozh dvrogozh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there open source driver available which supports AVS and AVS2?

va/va_dec_avs.h Outdated Show resolved Hide resolved
va/va_dec_avs.h Outdated Show resolved Hide resolved
@gitgjogh
Copy link
Author

gitgjogh commented Jul 27, 2023 via email

@XinfengZhang
Copy link
Contributor

I am ok to accept the AVS and AVS2 decode interfaces, but how to guarantee the usage? and guarantee the health, looks there are no open source project are using it, and no test application , no test coverage?
will there some open source project in future or some sample code added in https://github.com/intel/libva-utils

@gitgjogh
Copy link
Author

gitgjogh commented Sep 28, 2023

I am ok to accept the AVS and AVS2 decode interfaces, but how to guarantee the usage? and guarantee the health, looks there are no open source project are using it, and no test application , no test coverage? will there some open source project in future or some sample code added in https://github.com/intel/libva-utils

@XinfengZhang Please see intel/libva-utils#346, As mentioned, we also implemented ffmpeg-vaapi decoding for AVS and AVS2. Please see gitgjogh/FFmpeg#1. The PR would be submmitted to FFMpeg devel after this PR being accepted.

@gitgjogh
Copy link
Author

gitgjogh commented Nov 8, 2023

Hi @dvrogozh @XinfengZhang, is this PR still in reviewing?

gitgjogh pushed a commit to gitgjogh/FFmpeg that referenced this pull request Jan 19, 2024
see intel/libva#738

[Moore Threads](https://www.mthreads.com) (short for Mthreads) is a
Chinese GPU manufacturer. All our products, like MTTS70/MTTS80/.. ,
support AVS/AVS+ HW decoding at max 2k resolution.

Signed-off-by: jianfeng.zheng <[email protected]>
gitgjogh pushed a commit to gitgjogh/FFmpeg that referenced this pull request Jan 19, 2024
see intel/libva#738

[Moore Threads](https://www.mthreads.com) (short for Mthreads) is a
Chinese GPU manufacturer. All our products, like MTTS70/MTTS80/.. ,
support AVS2 8bit/10bit HW decoding at max 8k resolution.

Signed-off-by: jianfeng.zheng <[email protected]>
gitgjogh pushed a commit to gitgjogh/FFmpeg that referenced this pull request Jan 19, 2024
see intel/libva#738

[Moore Threads](https://www.mthreads.com) (short for Mthreads) is a
Chinese GPU manufacturer. All our products, like MTTS70/MTTS80/.. ,
support AVS2 8bit/10bit HW decoding at max 8k resolution.

Signed-off-by: jianfeng.zheng <[email protected]>
gitgjogh pushed a commit to gitgjogh/FFmpeg that referenced this pull request Jan 21, 2024
see intel/libva#738

[Moore Threads](https://www.mthreads.com) (short for Mthreads) is a
Chinese GPU manufacturer. All our products, like MTTS70/MTTS80/.. ,
support AVS/AVS+ HW decoding at max 2k resolution.

Signed-off-by: jianfeng.zheng <[email protected]>
gitgjogh pushed a commit to gitgjogh/FFmpeg that referenced this pull request Jan 21, 2024
uint16_t fixed_pic_qp_flag : 1;
uint16_t picture_qp : 6;
uint16_t loop_filter_disable_flag : 1;
uint16_t skip_mode_flag_flag : 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is skip_mode_flag_flag a typo ? I guess it should be skip_mode_flag.

DPY2TRACECTX(dpy, context, VA_INVALID_ID);

switch (type) {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add code to dump each field in avs2 buffer ?

DPY2TRACECTX(dpy, context, VA_INVALID_ID);

switch (type) {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add code to dump each field in avs buffer ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants