Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cpu version of torch sdpa until xpu version is fixed #2300

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Use cpu version of torch sdpa until xpu version is fixed #2300

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a380fd
Use cpu version of torch sdpa until xpu version is fixed
anmyachev Sep 20, 2024
d276bbb
Apply suggestions from code review
anmyachev Sep 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions benchmarks/triton_kernels_benchmark/flash_attention_fwd_benchmark.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,11 +226,14 @@ def benchmark(Z, H, N_CTX, D_HEAD, provider):
elif provider == 'triton':
triton_fn = lambda: forward(q, k, v, causal, sm_scale)
if benchmark_suit.USE_IPEX_OPTION:
# FIXME: use torch sdpa for result check after https://github.com/intel/intel-xpu-backend-for-triton/issues/2042 fixed
torch_fn = lambda: torch.nn.functional.scaled_dot_product_attention(
q, k, v, attn_mask=None, dropout_p=0.0, is_causal=False, scale=sm_scale).to(torch.float32)
atol = 1e-1 if N_CTX == 16384 else 1e-2
benchmark_suit.assert_close(triton_fn(), torch_fn(), atol=atol, rtol=1e-3, err_msg='triton to torch')
else:
# FIXME: use torch sdpa for result check after https://github.com/intel/intel-xpu-backend-for-triton/issues/2042 fixed
torch_fn = lambda: torch.nn.functional.scaled_dot_product_attention(q.cpu(), k.cpu(), v.cpu(
whitneywhtsang marked this conversation as resolved.
Show resolved Hide resolved
anmyachev marked this conversation as resolved.
Show resolved Hide resolved
), attn_mask=None, dropout_p=0.0, is_causal=False, scale=sm_scale).to(torch.float32)
atol = 1e-1 if N_CTX == 16384 else 1e-2
benchmark_suit.assert_close(triton_fn(), torch_fn(), atol=atol, rtol=1e-3, err_msg='triton to torch')
_, min_ms, max_ms, mean, cv = benchmark_suit.do_bench(triton_fn, warmup=10, rep=10, quantiles=quantiles,
fast_flush=False)

Expand Down