[MatchTargetSize] Extend for-loop canonicalization pattern #2045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julian Oppermann <[email protected]>
jopperm
requested review from
whitneywhtsang,
etiotto,
Dewei-Wang-sh and
a team
etiotto
reviewed
Aug 29, 2024
third_party/intel/lib/TritonIntelGPUTransforms/MatchTargetSize.cpp
Outdated
Show resolved
Hide resolved
third_party/intel/lib/TritonIntelGPUTransforms/MatchTargetSize.cpp
Outdated
Show resolved
Hide resolved
victor-eds
approved these changes
Aug 30, 2024
Dewei-Wang-sh
requested changes
Sep 2, 2024
|
|
||
| // If a results is used by another scf.for loop, we re-glue the individual | ||
| // results together to allow canonicalization of the dependent loop, too. | ||
| llvm::SmallDenseMap<OpResult, Value> reglueMap; |
There was a problem hiding this comment.
we can extend the new condition by handling the scf.yield operation.
no need to add a map.
if the scf.yield has a operand whose def is glue, then split it into two operands
There was a problem hiding this comment.
I've simplified the code to always insert glue ops after the loop, and replacing results immediately without storing them in a map.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support canonicalization of dependent
scf.forloops by re-gluing individual results after the loop.See #1947 for more context / the complete PoC.