Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEXMANAGE-430] Fixed Ping completed but cloudadapter shows error message #531

Merged
merged 1 commit into from
Jul 31, 2024
Merged

[NEXMANAGE-430] Fixed Ping completed but cloudadapter shows error message #531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions inbm/Changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- Fixed some Yocto issues found after migrating to scarthgap
- (NEXARL-195) Fixed device tree detection check on systems that implement only part of device tree
- (NEXARL-279) Fixed system would not be able to access secret volume after fwupd on Arrow Lake platform
- (NEXMANAGE-430) Fixed Ping completed but cloudadapter shows error message

### Security
- Bump requests from 2.31.0 to 2.32.2 in multiple agents resolving detected 3rd party CVE: CVE-2024-35195
Expand Down
5 changes: 3 additions & 2 deletions inbm/cloudadapter-agent/cloudadapter/cloud/client/inbs_cloud_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,8 +162,9 @@ def _handle_inbm_command_request(

request_id = item.request_id
logger.debug(f"Processing gRPC request: request_id {request_id}")
command_type = item.command.WhichOneof("inbm_command")

if self.get_dispatcher_state() == DEAD:
if self.get_dispatcher_state() == DEAD and command_type != "ping":
logger.error(
f"Dispatcher not in running state. Unable to process request - {request_id}"
)
Expand All @@ -175,7 +176,7 @@ def _handle_inbm_command_request(
)
continue

command_type = item.command.WhichOneof("inbm_command")

if command_type:
if command_type == "update_scheduled_operations":
# Convert operations to Dispatcher's ScheduleRequest
Expand Down
2 changes: 1 addition & 1 deletion inbm/cloudadapter-agent/tests/unit/cloud/client/test_inbs_cloud_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ def test_handle_command_when_dispatcher_is_not_up(self, inbs_client: InbsCloudCl

# Construct command using parameters
command = inbs_sb_pb2.HandleINBMCommandRequest(
request_id="123", command=inbs_sb_pb2.INBMCommand(ping=inbs_sb_pb2.Ping())
request_id="123", command=inbs_sb_pb2.INBMCommand(update_scheduled_operations=inbs_sb_pb2.UpdateScheduledOperations())
)
request_queue.put(command)
request_queue.put(None) # Sentinel to end the generator
Expand Down
Loading