operator: fix upgradeImages

[hj-johannes-lee]

Operatorhub bundle can have sha256 image tags that are put through env vars. When operator controller manager gets upgraded, its operands (plugin daemonsets) should be updated to the image in the env vars. But it has not been working properly because of wrong parsing.

Fix it to parse the image names that have sha256 tags correctly so env vars in operator can be used as intended.

[mythi]

For sha256 image tags, it has not been working properly.

Can you write how you expect it to work and how it works now. IIRC we decided SHA pinning is only for the env var approach.

[hj-johannes-lee]

If image is intel-qat-plugin@sha256:69858421d6abd38867f61844db2c3fa7275bf6c089efd547e7de98dfc0c90a1a

Before:
name was intel-qat-plugin@sha256
and upgradeImage was not working even though envVar is properly set.

For example, let's say there is 0.30.0 version of deployed operatorhub bundle using olm (as written in the link), and then let's say we deploy a qat plugin (0.30.0 version).
And then we update the bundle with the comamnd:

operator-sdk run bundle-upgrade intel/intel-deviceplugins-operator:0.31.0

Then, the qat-plugin is expected to be upgraded automatically according to the envVar, but it does not because the parsing has been wrong (intel-qat-plugin@sha256)

So,
I expect name to be intel-qat-plugin so that it can be updated when another sha256 is found from envVar.
And it works now like that, and tested with olm.

IIRC we decided SHA pinning is only for the env var approach.

Yeah, this fix is for fixing the misimplementation with env var approach.
Maybe I need to make the commit message more clear.