Use more generic name for NFD features host directory volume #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NFD hooks are deprecated and going away: kubernetes-sigs/node-feature-discovery#856 This makes the mount names more future-proof, and shows where later changes need to be done (to change operator mount directory, and switch hook-using deployments e.g. to feature files). Signed-off-by: Eero Tamminen <[email protected]>
eero-t
requested review from
hj-johannes-lee,
bart0sh,
mythi and
tkatila
as code owners
tkatila
approved these changes
Feb 9, 2023
@mythi Any idea when runners will be available? |
WIP, the host is down for some reason. |
|
@tkatila thanks! Let me know when GPU runner is up again, and I'll rebase this to HEAD, to force re-testing. |
hj-johannes-lee
requested changes
Feb 10, 2023
hj-johannes-lee
approved these changes
Feb 10, 2023
mythi
approved these changes
Feb 10, 2023
|
@eero-t e2e gpu became online and tested ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NFD hooks are deprecated and going away:
kubernetes-sigs/node-feature-discovery#856
This makes the mount names more future-proof, and shows where later changes need to be done (to change operator mount directory, and switch hook-using deployments e.g. to feature files).
I decided to split this from PR #1118, so that same change can be done for all plugins (GPU + SGX), to avoid complicating later switch away from hooks. Added SGX part is not tested, but that change is identical to GPU one.