Skip to content

Commit

Permalink
Revert "Limit number of CCS engines on PVC"
Browse files Browse the repository at this point in the history
This reverts commit 8f8370b.

Signed-off-by: Mateusz Jablonski <[email protected]>
  • Loading branch information
JablonskiMateusz authored and Compute-Runtime-Automation committed Aug 8, 2022
1 parent ed0c361 commit 3b3d402
Show file tree
Hide file tree
Showing 8 changed files with 0 additions and 66 deletions.
10 changes: 0 additions & 10 deletions shared/source/execution_environment/execution_environment.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -199,14 +199,4 @@ void ExecutionEnvironment::parseAffinityMask() {

rootDeviceEnvironments.swap(filteredEnvironments);
}

void ExecutionEnvironment::adjustCcsCount() const {
for (auto &rootDeviceEnvironment : rootDeviceEnvironments) {
UNRECOVERABLE_IF(!rootDeviceEnvironment);
auto hwInfo = rootDeviceEnvironment->getMutableHardwareInfo();
auto hwInfoConfig = HwInfoConfig::get(hwInfo->platform.eProductFamily);
hwInfoConfig->adjustNumberOfCcs(*hwInfo);
}
}

} // namespace NEO
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ class ExecutionEnvironment : public ReferenceTrackedObject<ExecutionEnvironment>
virtual void prepareRootDeviceEnvironments(uint32_t numRootDevices);
void prepareRootDeviceEnvironment(const uint32_t rootDeviceIndexForReInit);
void parseAffinityMask();
void adjustCcsCount() const;
void sortNeoDevices();
void sortNeoDevicesDRM();
void sortNeoDevicesWDDM();
Expand Down
2 changes: 0 additions & 2 deletions shared/source/os_interface/device_factory.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,6 @@ bool DeviceFactory::prepareDeviceEnvironmentsForProductFamilyOverride(ExecutionE
}

executionEnvironment.parseAffinityMask();
executionEnvironment.adjustCcsCount();
executionEnvironment.calculateMaxOsContextCount();
return true;
}
Expand Down Expand Up @@ -159,7 +158,6 @@ bool DeviceFactory::prepareDeviceEnvironments(ExecutionEnvironment &executionEnv

executionEnvironment.sortNeoDevices();
executionEnvironment.parseAffinityMask();
executionEnvironment.adjustCcsCount();
executionEnvironment.calculateMaxOsContextCount();

return true;
Expand Down
2 changes: 0 additions & 2 deletions shared/source/os_interface/hw_info_config.h
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,6 @@ class HwInfoConfig {
virtual bool isAssignEngineRoundRobinSupported() const = 0;
virtual uint32_t getL1CachePolicy() const = 0;
virtual bool isEvictionWhenNecessaryFlagSupported() const = 0;
virtual void adjustNumberOfCcs(HardwareInfo &hwInfo) const = 0;

MOCKABLE_VIRTUAL ~HwInfoConfig() = default;

Expand Down Expand Up @@ -235,7 +234,6 @@ class HwInfoConfigHw : public HwInfoConfig {
bool isAssignEngineRoundRobinSupported() const override;
uint32_t getL1CachePolicy() const override;
bool isEvictionWhenNecessaryFlagSupported() const override;
void adjustNumberOfCcs(HardwareInfo &hwInfo) const override;

protected:
HwInfoConfigHw() = default;
Expand Down
2 changes: 0 additions & 2 deletions shared/source/os_interface/hw_info_config.inl
Original file line number Diff line number Diff line change
Expand Up @@ -480,6 +480,4 @@ uint32_t HwInfoConfigHw<gfxProduct>::getL1CachePolicy() const {
return L1CachePolicyHelper<gfxProduct>::getL1CachePolicy();
}

template <PRODUCT_FAMILY gfxProduct>
void HwInfoConfigHw<gfxProduct>::adjustNumberOfCcs(HardwareInfo &hwInfo) const {}
} // namespace NEO
Original file line number Diff line number Diff line change
Expand Up @@ -193,9 +193,4 @@ bool HwInfoConfigHw<gfxProduct>::isComputeDispatchAllWalkerEnableInCfeStateRequi
template <>
bool HwInfoConfigHw<gfxProduct>::isIpSamplingSupported(const HardwareInfo &hwInfo) const {
return PVC::isXt(hwInfo);
}

template <>
void HwInfoConfigHw<gfxProduct>::adjustNumberOfCcs(HardwareInfo &hwInfo) const {
hwInfo.gtSystemInfo.CCSInfo.NumberOfCCSEnabled = 1;
}
1 change: 0 additions & 1 deletion shared/test/unit_test/xe_hpc_core/pvc/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ if(TESTS_PVC)
set(NEO_SHARED_TESTS_PVC
${CMAKE_CURRENT_SOURCE_DIR}/CMakeLists.txt
${CMAKE_CURRENT_SOURCE_DIR}/device_binary_format_ar_tests_pvc.cpp
${CMAKE_CURRENT_SOURCE_DIR}/device_tests_pvc.cpp
${CMAKE_CURRENT_SOURCE_DIR}/dispatch_walker_tests_pvc.cpp
${CMAKE_CURRENT_SOURCE_DIR}/hw_info_tests_pvc.cpp
${CMAKE_CURRENT_SOURCE_DIR}/product_config_helper_tests_pvc.cpp
Expand Down
43 changes: 0 additions & 43 deletions shared/test/unit_test/xe_hpc_core/pvc/device_tests_pvc.cpp

This file was deleted.

0 comments on commit 3b3d402

Please sign in to comment.