This repository has been archived by the owner on Jan 18, 2023. It is now read-only.
don't exit on exceptions during uninstall #239
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes error when not all resources are removed when running `cmk uninstall` command and trying to remove object that has been already deleted. Instead, a warning message is displayed when the resource already doesn't exist and the uninstall script continues execution, trying to remove remaining resources in the best effort mode.
cbf123
added a commit
to cbf123/CPU-Manager-for-Kubernetes
that referenced
this pull request
May 23, 2019
When doing an uninstall it's not really an error if we try to remove something that has already been removed. Add a few checks to cover this scenario. There's an upstream patch proposed which handles this a bit differently which we may want to pick up instead, it basically just ignores all errors on uninstall rather than being selective. intel#239 Signed-off-by: Chris Friesen <[email protected]>
cbf123
added a commit
to cbf123/CPU-Manager-for-Kubernetes
that referenced
this pull request
Oct 24, 2019
When doing an uninstall it's not really an error if we try to remove something that has already been removed. Add a few checks to cover this scenario. There's an upstream patch proposed which handles this a bit differently which we may want to pick up instead, it basically just ignores all errors on uninstall rather than being selective. intel#239 Signed-off-by: Chris Friesen <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes error when not all resources are removed when running
cmk uninstallcommand and trying to remove object that has been already deleted.Instead, a warning message is displayed when the resource already doesn't exist and the uninstall script continues execution, trying to remove remaining resources in the best effort mode.
Fixes #238.