Allow per user based kubelogin lock file #909
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this feature
In a multi-user environment we need to be able to simultaneously have users login to a kubernetes cluster.
Updating this method to go from using the os temp directory to using the user home directory to create the generated lock filename allows for multi-user capable login. If the user doesn't have the proper environment variable set (
HOME
,USERPROFILE
,home
), it falls back to the default temp directory.Current workaround
The current workaround for this functionality is to temporarily set
TMPDIR
env variable to the users home directory and then reset it to the temp directoryFor example:
This will work for the time being but I would love to not have to implement this workaround and have it part of the core functionality of kubelogin's
master
branch.