Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom task qc #724

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Custom task qc #724

merged 2 commits into from
Jan 31, 2024

Conversation

k1o0
Copy link
Contributor

@k1o0 k1o0 commented Jan 31, 2024

Resolves #722.

  • TaskQC._get_checks method for overloading in subclass
  • get_bpodqc_metrics_frame function moved to TaskQC method;
  • QC kwarg for behaviour task run_qc method allows passing of custom TaskQC class
  • Deprecated videopc params functions in ibllib.pipes.misc
  • raise ValueError in BehaviourTask.get_protocol when task protocol is ambiguous

k1o0 added 2 commits January 31, 2024 17:57
get_bpodqc_metrics_frame moved from function to TaskQC method;
QC kwarg for behaviour task run_qc method allows passing of custom
TaskQC class;
deprecated videopc params functions in ibllib.pipes.misc;
raise in BehaviourTask.get_protocol when task protocol ambiguous
@k1o0 k1o0 merged commit 4f763c0 into develop Jan 31, 2024
4 checks passed
@k1o0 k1o0 deleted the custom_task_qc branch January 31, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant