Merge pull request #662 from int-brain-lab/wheel_alignment

better logging and release notes
int-brain-lab · Oct 12, 2023 · bfa88e5 · bfa88e5
2 parents 3bdaf87 + c9d7127
commit bfa88e5
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/ibllib/io/extractors/camera.py b/ibllib/io/extractors/camera.py
@@ -160,13 +160,13 @@ def _extract(self, sync=None, chmap=None, video_path=None, sync_label='audio',
             motion_class = vmotion.MotionAlignmentFullSession(self.session_path, self.label, sync='nidq', upload=True)
             new_times = motion_class.process()
             if not motion_class.qc_outcome:
-                raise ValueError(f'Wheel alignment failed to pass qc: {motion_class.qc}')
+                raise ValueError(f'Wheel alignment for {self.label} camera failed to pass qc: {motion_class.qc}')
             else:
-                _logger.warning(f'Wheel alignment successful, qc: {motion_class.qc}')
+                _logger.warning(f'Wheel alignment for {self.label} camera successful, qc: {motion_class.qc}')
                 return new_times
 
         except Exception as err:
-            _logger.critical(f'Failed to align with wheel: {err}')
+            _logger.critical(f'Failed to align with wheel for {self.label} camera: {err}')
 
         if length < raw_ts.size:
             df = raw_ts.size - length

diff --git a/release_notes.md b/release_notes.md
@@ -1,3 +1,7 @@
+## Develop
+- Add full video wheel motion alignment code to ibllib.io.extractors.video_motion module
+- Change FPGA camera extractor to attempt wheel alignment if audio alignment fails
+
 ## Release Notes 2.26
 
 ### features