Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check to see if dtype has a "shape" when checking object shapes #124

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Add check to see if dtype has a "shape" when checking object shapes #124

merged 2 commits into from
Jul 17, 2024

Conversation

chris-langfield
Copy link
Contributor

Currently in load_object, there is an attribute error when loading an NpzFile because this type does not have a shape. This adds the same check done in check_dimensions to the check done in load_object

@chris-langfield chris-langfield requested a review from k1o0 July 16, 2024 20:17
k1o0
k1o0 approved these changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@k1o0 k1o0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, want to me release immediately?

@chris-langfield
Copy link
Contributor Author

Yes please! :)

@k1o0 k1o0 merged commit c7961b4 into main Jul 17, 2024
4 checks passed
@k1o0 k1o0 deleted the checking_shapes_npz branch July 17, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k1o0 k1o0 k1o0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chris-langfield @k1o0