Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade flutter_rust_bridge to v2.2.0 #182

Merged
merged 23 commits into from
Aug 22, 2024
Merged

Upgrade flutter_rust_bridge to v2.2.0 #182

merged 23 commits into from
Aug 22, 2024

Conversation

alexlapa
Copy link
Contributor

@alexlapa alexlapa commented Aug 20, 2024 •
edited by tyranron
Loading

Synopsis

Upgrade flutter_rust_bridge to v2.2.0

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
    • Has assignee
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@alexlapa
wip
b39b955
@alexlapa
wip
e8979e8
@alexlapa
Merge branch 'master' into upgrade-frb
68c7258 
# Conflicts:
#	Cargo.lock
#	flutter/example/pubspec.lock
#	flutter/example/pubspec.yaml
#	flutter/pubspec.yaml
@alexlapa
wip
a04515f
@alexlapa
wip
c904c81
@alexlapa
Merge branch 'master' into upgrade-frb
7997a6b 
# Conflicts:
#	Cargo.lock
#	Cargo.toml
#	flutter/example/pubspec.lock
#	flutter/example/pubspec.yaml
#	flutter/pubspec.yaml
@alexlapa
corrections
fac2585
@alexlapa
corrections
756027a
@alexlapa
corrections
7274227
@alexlapa
corrections
99fa69d
@alexlapa
for test revert later
d3b452f
@alexlapa
corrections
facdbe8
@alexlapa
Revert "for test revert later"
d841177 
This reverts commit d3b452f.
@alexlapa
corrections
ef1d238
@alexlapa alexlapa added enhancement Improvement of existing features or bugfix k::toolchain Related to project toolchain k::dependencies Pull requests that update a dependency file labels Aug 20, 2024
@alexlapa alexlapa self-assigned this Aug 20, 2024
@alexlapa
Copy link
Contributor Author

alexlapa commented Aug 21, 2024 •
edited by evdokimovs
Loading

FCM:

Upgrade `flutter_rust_bridge` to 2.2.0 version (#182)

Additionally:
- re-enable MacOS/iOS tests running on CI

@alexlapa alexlapa marked this pull request as ready for review August 21, 2024 09:48
tyranron
tyranron reviewed Aug 21, 2024
View reviewed changes
src/api/dart/api/room.rs Outdated Show resolved Hide resolved
@tyranron tyranron added the k::refactor Refactoring, technical debt elimination and other improvements of existing code base label Aug 21, 2024
tyranron
tyranron requested changes Aug 21, 2024
View reviewed changes
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexlapa seems that using SendWrapper indeed revealed some multi-thread usage, as src/api/dart/api/local_media_track.rs:109:5 now panics.

Could you look into it?

@tyranron tyranron enabled auto-merge (squash) August 22, 2024 13:28
@tyranron tyranron merged commit 5a41f54 into master Aug 22, 2024
51 of 52 checks passed
@tyranron tyranron deleted the upgrade-frb branch August 22, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

@evdokimovs evdokimovs evdokimovs approved these changes

Assignees

@alexlapa alexlapa

Labels
enhancement Improvement of existing features or bugfix k::dependencies Pull requests that update a dependency file k::refactor Refactoring, technical debt elimination and other improvements of existing code base k::toolchain Related to project toolchain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexlapa @tyranron @evdokimovs