Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synopsis
Client currently incorrectly sets list of preferred codecs, picking the first one that fits according to
getCapabilities
result disregarding the fact that each codec can have multiple entries with different settings. So if we limit server capabilities to VP9 withprofile-0
, client might set VP9 profile-2 viasetCodecpreferences
thus failing to negotiate.Checklist
k::
labels applied