Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Course Smart Search "How it works" screen #2967

Open
wants to merge 8 commits into
base: feature/MBL-17906-Course-Smart-Search
Choose a base branch
from
Open

Course Smart Search "How it works" screen #2967

wants to merge 8 commits into from

Conversation

suhaibabsi-inst
Copy link
Contributor

@suhaibabsi-inst suhaibabsi-inst commented Nov 12, 2024 •
edited by vargaat
Loading

refs: MBL-18010
affects: Student
release note: Course Smart Search "How it works" screen

Related PR(s):
#2932

Test Plan

  • Make sure to activate "Smart Search" on account & course level. See here.
  • Login to Student app.
  • Go to courses, open one of the courses.
  • You should expect a search icon shown on the top-right button. Follow on the experience.
    • Tap on question-mark icon button
    • A sheet is shown with help content about smart search

Screenshot

Help Screen

Video Record

video_record.mp4

Checklist

  • Follow-up e2e test ticket created
  • A11y checked
  • Tested on phone
  • Tested on tablet
  • Tested in dark mode
  • Tested in light mode
  • Approve from product

@suhaibabsi-inst
How-it-works screen content
6c4c5f8
@suhaibabsi-inst
Few tweaks
d0e5c17 
refs: MBL-18010
affects: Student
release note: Course Smart Search "How it works" screen

test plan: See PR description
@inst-danger
Copy link
Contributor

inst-danger commented Nov 12, 2024 •
edited by jira bot
Loading

Warnings
⚠️ One or more files are below the minimum test coverage 50%

Release Note:

Course Smart Search "How it works" screen

Affected Apps: Student

MBL-18010

Coverage New % Master % Delta
Canvas iOS 91.23% 91.43% -0.2%
Core/Core/Search/SearchUtils.swift 42% -- --
Core/Core/Courses/SmartSearch/Model/CourseSmartSearch.swift 46.15% -- --
Core/Core/Courses/SmartSearch/Model/CourseSmartSearchDescriptor.swift 32.43% -- --
Core/Core/Assignments/AssignmentList/ViewModel/AssignmentListViewModel.swift 47.8% 47.8% 0%

Generated by 🚫 dangerJS against ec46c2d

@suhaibabsi-inst suhaibabsi-inst mentioned this pull request Nov 12, 2024
Open
7 tasks
@suhaibabsi-inst suhaibabsi-inst marked this pull request as ready for review November 13, 2024 09:12
@inst-danger
Copy link
Contributor

Student Build QR Code:

vargaat
vargaat approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@vargaat vargaat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vargaat vargaat vargaat approved these changes

@szabinst szabinst Awaiting requested review from szabinst szabinst is a code owner

@rh12 rh12 Awaiting requested review from rh12 rh12 is a code owner

@ndrsszsz ndrsszsz Awaiting requested review from ndrsszsz ndrsszsz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@suhaibabsi-inst @inst-danger @vargaat