-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
calculate the terminal value in a DCF model #1298
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Colin Robb <[email protected]>
Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉 I support the following commands:
Note Results or Errors of these commands will be posted as a pull request check in the Checks section below Note Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers instructlab-bot-triagers instructlab-bot-maintainers oversight-committee]] teams are allowed to run these commands. |
removed the colons; this now passed a YAML validator test. Signed-off-by: Colin Robb <[email protected]>
From a taxonomy tree perspective, this would go here:
In the DDC summaries, "economics" is under "social sciences" which is separate from "science" but for InstructLab, I think we should just put social sciences under our science main category. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the linting issues.
Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉 I support the following commands:
Note Results or Errors of these commands will be posted as a pull request check in the Checks section below Note Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers instructlab-bot-triagers instructlab-bot-maintainers oversight-committee]] teams are allowed to run these commands. |
I fixed the trailing spaces issues and made it version 3. Signed-off-by: Colin Robb <[email protected]>
Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉 I support the following commands:
Note Results or Errors of these commands will be posted as a pull request check in the Checks section below Note Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers instructlab-bot-triagers instructlab-bot-maintainers oversight-committee]] teams are allowed to run these commands. |
Signed-off-by: Colin Robb <[email protected]>
I updated the qna and addressed the linting issues. I also added the attribution.txt file with the source. |
This pull request has been automatically marked as stale because it has not had activity within 15 days. It will be automatically closed if no further activity occurs within the next 31 days. |
Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉 I support the following commands:
Note Results or Errors of these commands will be posted as a pull request check in the Checks section below Note Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers instructlab-bot-triagers instructlab-bot-maintainers oversight-committee]] teams are allowed to run these commands. |
Noticing this has been marked stale; I think my updates from 2 weeks ago should be good now. Let me know if there's anything else I need to do. Thanks. |
Not sure if the triage team needed to review/discuss this one, but I had suggested a different location in the taxonomy tree for this one: #1298 (comment) |
…/grounded/science/social_sciences/economics/dcf_model Changing to recommended location. Signed-off-by: Colin Robb <[email protected]>
…_skills/grounded/science/social_sciences/economics/attribution.txt Changing to recommended location Signed-off-by: Colin Robb <[email protected]>
Okay - I updated to the recommended location. |
Hi! Until we have our community model builds back up and running, many PRs will be held off. We are hoping to have them running again soon, and if you have any specific questions don't hesitate to comment here or reach out to #triage in slack. |
This pull request has been automatically marked as stale because it has not had activity within 15 days. It will be automatically closed if no further activity occurs within the next 31 days. |
Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉 I support the following commands:
Note Results or Errors of these commands will be posted as a pull request check in the Checks section below Note Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers instructlab-bot-triagers instructlab-bot-maintainers oversight-committee]] teams are allowed to run these commands. |
Just wanted to check in and see if there is anything else to progress this contribution? I think it's ready once the community model builds are back up. |
We had a long time before the community model build is running at full capacity, unfortunately. We are attempting to get it working but have encountered some logistical issues. We are working on them, but it's slow going. |
Adding a skill to calculate the terminal value in a DCF model. Currently, the model only gets this question about 1/2 way correct. this should help get it all the way there!
Contribution checklist
ilab generate
ilab generate
qna.yaml
file contains at least 5seed_examples
qna.yaml
file was linted and prettified (yaml-validator can do both)attribution.txt
file in the same folder as theqna.yaml
file