Wrap in a transaction operations a respondents list #2376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matiasgarciaisaia
approved these changes
Dec 6, 2024
| }, | ||
| () => { | ||
| // Reject with original error | ||
| Promise.reject(e) |
There was a problem hiding this comment.
The error we get doing this is JSON.parse: unexpected character at line 1 column 1 of the JSON data, which isn't really useful for the user. Without this block, we get an equally useless Unhandled promise rejection error.
I'd keep this, anyways, so we're closer to something useful. We should eventually change the endpoint to reply a JSON error.
There was a problem hiding this comment.
In my tests the JSON error didn't bubble up high enough, it logged on the browser console but no feedback to the user. The outer error did show the popup with not much information. It could have been replaced by new Error("some message"), still not very friendly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes