Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves build tasks from build.sh to Dockerfile (#2223) #2244

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Moves build tasks from build.sh to Dockerfile (#2223) #2244

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ea89cb
Moves build tasks from build.sh to Dockerfile (#2223)
nthiad Apr 12, 2023
9c902e5
Multi-stage dockerfile build for #2223
nthiad Apr 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ FROM elixir:1.10 AS dev
RUN sed -i '/^mozilla\/DST_Root_CA_X3/s/^/!/' /etc/ca-certificates.conf && update-ca-certificates -f

RUN apt -q update && \
apt -q install -y default-mysql-client inotify-tools festival && \
apt -q install -y default-mysql-client inotify-tools festival yarnpkg && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not using yarn in the development image (since we're running a webpack service in the docker-compose.yml). And we definitely not need it in the production one.

apt -q install -y --no-install-recommends ffmpeg libaacs0 && \
apt -q clean && rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*

Expand All @@ -19,13 +19,16 @@ ADD mix.exs mix.lock /app/
ADD config /app/config
WORKDIR /app

RUN mix deps.get --only prod
RUN mix deps.get
RUN mix deps.compile

ADD . /app
RUN mix compile
RUN mix phx.digest

RUN yarnpkg install --no-progress
RUN yarnpkg deploy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add yet another stage in the file, using the same image we're running for the webpack service right now, and build the UI as we're now doing in the build.sh file - but in this Dockerfile, so we can then COPY --from=webpack those resulting files.


ENV PORT=80
EXPOSE 80

Expand Down