Move API routes concerns back to api.js

Those URLs in the RespondentIndex.jsx smelled. See #2350
instedd · Nov 13, 2024 · 84b9840 · 84b9840
1 parent b633f1a
commit 84b9840
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 9 deletions.
diff --git a/assets/js/api.js b/assets/js/api.js
@@ -683,6 +683,17 @@ export const refreshDispositionHistoryLink = (projectId, surveyId) => {
   )
 }
 
+export const resultsFileUrl = (projectId, surveyId, q) =>
+  `/api/v1/projects/${projectId}/surveys/${surveyId}/respondents/results_csv${
+    (q && `?q=${encodeURIComponent(q)}`) || ""
+  }`
+export const dispositionHistoryFileUrl = (projectId, surveyId) =>
+  `/api/v1/projects/${projectId}/surveys/${surveyId}/respondents/disposition_history`
+export const incentivesFileUrl = (projectId, surveyId) =>
+  `/api/v1/projects/${projectId}/surveys/${surveyId}/respondents/incentives`
+export const interactionsFileUrl = (projectId, surveyId) =>
+  `/api/v1/projects/${projectId}/surveys/${surveyId}/respondents/interactions`
+
 export const generateResults = (projectId, surveyId, filter) =>
   apiPostJSON(`projects/${projectId}/surveys/${surveyId}/respondents/results`, null, { q: filter })
 export const generateDispositionHistory = (projectId, surveyId) =>

diff --git a/assets/js/components/respondents/RespondentIndex.jsx b/assets/js/components/respondents/RespondentIndex.jsx
@@ -164,24 +164,22 @@ class RespondentIndex extends Component<Props, State> {
   resultsFileUrl(applyUserFilter = false) {
     const { projectId, surveyId, filter } = this.props
     const q = (applyUserFilter && filter) || null
-    return `/api/v1/projects/${projectId}/surveys/${surveyId}/respondents/results_csv${
-      (q && `?q=${encodeURIComponent(q)}`) || ""
-    }`
+    return api.resultsFileUrl(projectId, surveyId, q)
   }
-  
+
   dispositionHistoryFileUrl() {
     const { projectId, surveyId } = this.props
-    return `/api/v1/projects/${projectId}/surveys/${surveyId}/respondents/disposition_history`
+    return api.dispositionHistoryFileUrl(projectId, surveyId)
   }
-  
+
   incentivesFileUrl() {
     const { projectId, surveyId } = this.props
-    return `/api/v1/projects/${projectId}/surveys/${surveyId}/respondents/incentives`
+    return api.incentivesFileUrl(projectId, surveyId)
   }
-  
+
   interactionsFileUrl() {
     const { projectId, surveyId } = this.props
-    return `/api/v1/projects/${projectId}/surveys/${surveyId}/respondents/interactions`
+    return api.interactionsFileUrl(projectId, surveyId)
   }
 
   sortBy(name) {