Ignore Google Maps tests #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The two disabled tests fail due to not having a working Google Maps API key. The UI fails trying to load the map, and that JavaScript error breaks the UI interactions and navigation. I'm temporarily disabling the tests until we fix the UI or provide a valid API Key.
Mirroring what's done in the Docker environment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some specs depend on Google Maps loading OK in the site, but for the test environment we don't have a working API key - so they fail.
This PR marks them as pending, so we can keep working on ResourceMap. We should eventually fix the UI to work anyways with the maps disabled.