Consumers autoselect #722
Merged
Consumers autoselect #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting the project up yields these changes in the package-json.lock, so its format must have changed somewhere down the line. These changes have been automatically generated by npm.
In production, the amount of datasets to pick from was getting large and unsorted, so the UX was really bad. This change mimics the Region selection, with an autoselect control for the users to filter the available options. See #717
Comment on lines
+24
to
+31
| (let [props (merge {:choices @(rf/subscribe [:sources/dropdown-options]) | ||
| :label-fn :name | ||
| :render-fn (fn [source] [:div.option-row | ||
| [:span (:name source)] | ||
| [:span.option-context (:value source)]])} | ||
| attrs)] | ||
| (into [filter-select/single-dropdown] (mapcat identity props)))) |
There was a problem hiding this comment.
This view is essentially the same as the one for the regions-dropdown-component, so I guess there's a component we should extract - but I didn't trust my ClojureScript-foo enough to go for it now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the
Consumers Datasetdropdown with an autoselect control like the one we have for Region selection, with a filter.Fixes #717